linux-kernel - Re: [PATCH] fork: fail on non-zero higher 32 bits of args.exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Sep 2019 15:20:31 +0300
From:   "Dmitry V. Levin" <ldv@...linux.org>
To:     Eugene Syromiatnikov <esyr@...hat.com>,
        Christian Brauner <christian@...uner.io>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Eric Biederman <ebiederm@...ssion.com>,
        Oleg Nesterov <oleg@...hat.com>
Subject: Re: [PATCH] fork: fail on non-zero higher 32 bits of args.exit_signal

On Tue, Sep 10, 2019 at 12:57:11PM +0100, Eugene Syromiatnikov wrote:
> Previously, higher 32 bits of exit_signal fields were lost when
> copied to the kernel args structure (that uses int as a type for the
> respective field).  Fail with EINVAL if these are set as it looks like
> there's no sane reason to accept them.
> 
> * kernel/fork.c (copy_clone_args_from_user): Fail with -EINVAL if
> args.exit_signal converted to unsigned int is not equal to the original
> value.
> 
> Signed-off-by: Eugene Syromiatnikov <esyr@...hat.com>

Reviewed-by: Dmitry V. Levin <ldv@...linux.org>


-- 
ldv