linux-kernel - Re: [PATCH 0/3] Remove __online_page_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b8ceaa6f-a0b3-515f-4d11-c9a633eb95c4@redhat.com>
Date:   Tue, 10 Sep 2019 14:58:19 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Souptick Joarder <jrdr.linux@...il.com>,
        "Kirill A. Shutemov" <kirill@...temov.name>
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        sashal@...nel.org, Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>, sstabellini@...nel.org,
        Andrew Morton <akpm@...ux-foundation.org>, osalvador@...e.com,
        Michal Hocko <mhocko@...e.com>, pasha.tatashin@...een.com,
        Dan Williams <dan.j.williams@...el.com>,
        richard.weiyang@...il.com, Qian Cai <cai@....pw>,
        linux-hyperv@...r.kernel.org, xen-devel@...ts.xenproject.org,
        Linux-MM <linux-mm@...ck.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] Remove __online_page_set_limits()

On 10.09.19 14:56, Souptick Joarder wrote:
> On Mon, Sep 9, 2019 at 9:12 PM Kirill A. Shutemov <kirill@...temov.name> wrote:
>>
>> On Sun, Sep 08, 2019 at 03:17:01AM +0530, Souptick Joarder wrote:
>>> __online_page_set_limits() is a dummy function and an extra call
>>> to this can be avoided.
>>>
>>> As both of the callers are now removed, __online_page_set_limits()
>>> can be removed permanently.
>>>
>>> Souptick Joarder (3):
>>>   hv_ballon: Avoid calling dummy function __online_page_set_limits()
>>>   xen/ballon: Avoid calling dummy function __online_page_set_limits()
>>>   mm/memory_hotplug.c: Remove __online_page_set_limits()
>>>
>>>  drivers/hv/hv_balloon.c        | 1 -
>>>  drivers/xen/balloon.c          | 1 -
>>>  include/linux/memory_hotplug.h | 1 -
>>>  mm/memory_hotplug.c            | 5 -----
>>>  4 files changed, 8 deletions(-)
>>
>> Do we really need 3 separate patches to remove 8 lines of code?
> 
> I prefer to split into series of 3 which looks more clean. But I am ok
> with other option.
> Would you like to merge into single one ?
> 

If you have to resend, you could squash them into one. If not, I think
this is okay ...

-- 

Thanks,

David / dhildenb