linux-kernel - Re: [PATCH] KVM: s390: kvm_s390_vm_start_migration: check dirty_bitmap before using it as target for memset()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190910181043.GB4313@osiris>
Date:   Tue, 10 Sep 2019 20:10:43 +0200
From:   Heiko Carstens <heiko.carstens@...ibm.com>
To:     Igor Mammedov <imammedo@...hat.com>
Cc:     linux-kernel@...r.kernel.org, borntraeger@...ibm.com,
        david@...hat.com, cohuck@...hat.com, frankja@...ux.ibm.com,
        gor@...ux.ibm.com, imbrenda@...ux.ibm.com,
        linux-s390@...r.kernel.org, kvm@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] KVM: s390: kvm_s390_vm_start_migration: check
 dirty_bitmap before using it as target for memset()

On Tue, Sep 10, 2019 at 09:02:15AM -0400, Igor Mammedov wrote:
> Make sure that ms->dirty_bitmap is set before using it or
> print a warning and return -ENIVAL otherwise.
...
> v2:
>    - drop WARN()
...
> +		if (!ms->dirty_bitmap)
> +			return -EINVAL;

The patch description needs an update. ;)