linux-kernel - Re: [PATCH] crypto: talitos - fix missing break in switch statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2c4faf9-9b10-882d-57db-bcbc3ed2a025@c-s.fr>
Date:   Tue, 10 Sep 2019 08:06:46 +0200
From:   Christophe Leroy <christophe.leroy@....fr>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: talitos - fix missing break in switch statement



Le 09/09/2019 à 07:29, Gustavo A. R. Silva a écrit :
> Add missing break statement in order to prevent the code from falling
> through to case CRYPTO_ALG_TYPE_AHASH.
> 
> Fixes: aeb4c132f33d ("crypto: talitos - Convert to new AEAD interface")
> Cc: stable@...r.kernel.org
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Reviewed-by: Christophe Leroy <christophe.leroy@....fr>

> ---
>   drivers/crypto/talitos.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
> index c9d686a0e805..4818ae427098 100644
> --- a/drivers/crypto/talitos.c
> +++ b/drivers/crypto/talitos.c
> @@ -3140,6 +3140,7 @@ static int talitos_remove(struct platform_device *ofdev)
>   			break;
>   		case CRYPTO_ALG_TYPE_AEAD:
>   			crypto_unregister_aead(&t_alg->algt.alg.aead);
> +			break;
>   		case CRYPTO_ALG_TYPE_AHASH:
>   			crypto_unregister_ahash(&t_alg->algt.alg.hash);
>   			break;
>