linux-kernel - [PATCH] cpupower : Handle set and info subcommands for powerpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190911095424.49605-1-huntbag@linux.vnet.ibm.com>
Date:   Wed, 11 Sep 2019 04:54:24 -0500
From:   Abhishek Goel <huntbag@...ux.vnet.ibm.com>
To:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     shuah@...nel.org, trenn@...e.com,
        Abhishek Goel <huntbag@...ux.vnet.ibm.com>
Subject: [PATCH] cpupower : Handle set and info subcommands for powerpc

Cpupower tool has set and info options which are not being used by
POWER machines. For powerpc, we will return directly for these two
subcommands. This removes the ambiguous error message while using set
option in case of power systems.

Signed-off-by: Abhishek Goel <huntbag@...ux.vnet.ibm.com>
---
 tools/power/cpupower/utils/cpupower-info.c | 5 +++++
 tools/power/cpupower/utils/cpupower-set.c  | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/tools/power/cpupower/utils/cpupower-info.c b/tools/power/cpupower/utils/cpupower-info.c
index 4c9d342b70ff..674b707a76af 100644
--- a/tools/power/cpupower/utils/cpupower-info.c
+++ b/tools/power/cpupower/utils/cpupower-info.c
@@ -39,6 +39,11 @@ int cmd_info(int argc, char **argv)
 	} params = {};
 	int ret = 0;
 
+	#ifdef __powerpc__
+	printf(_("Cannot read info as system does not support performance bias setting\n"));
+	return 0;
+	#endif
+
 	setlocale(LC_ALL, "");
 	textdomain(PACKAGE);
 
diff --git a/tools/power/cpupower/utils/cpupower-set.c b/tools/power/cpupower/utils/cpupower-set.c
index 3cd95c6cb974..c95b29278780 100644
--- a/tools/power/cpupower/utils/cpupower-set.c
+++ b/tools/power/cpupower/utils/cpupower-set.c
@@ -41,6 +41,11 @@ int cmd_set(int argc, char **argv)
 	int perf_bias = 0;
 	int ret = 0;
 
+	#ifdef __powerpc__
+	printf(_("System does not support performance bias setting\n"));
+	return 0;
+	#endif
+
 	setlocale(LC_ALL, "");
 	textdomain(PACKAGE);
 
-- 
2.17.1