linux-kernel - Re: [PATCH] ASoC: fsl_sai: Implement set_bclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190911110017.GA2036@sirena.org.uk>
Date:   Wed, 11 Sep 2019 12:00:17 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Nicolin Chen <nicoleotsuka@...il.com>
Cc:     Daniel Baluta <daniel.baluta@....com>, festevam@...il.com,
        shengjiu.wang@....com, Xiubo.Lee@...il.com, timur@...nel.org,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Viorel Suman <viorel.suman@....com>,
        NXP Linux Team <linux-imx@....com>
Subject: Re: [PATCH] ASoC: fsl_sai: Implement set_bclk_ratio

On Thu, Sep 05, 2019 at 06:29:39PM -0700, Nicolin Chen wrote:
> On Sat, Aug 31, 2019 at 12:59:10AM +0300, Daniel Baluta wrote:

> > This is to allow machine drivers to set a certain bitclk rate
> > which might not be exactly rate * frame size.

> Just a quick thought of mine: slot_width and slots could be
> set via set_dai_tdm_slot() actually, while set_bclk_ratio()
> would override that one with your change. I'm not sure which
> one could be more important...so would you mind elaborating
> your use case?

The reason we have both operations is partly that some hardware
can configure the ratio but not do TDM and partly that setting
TDM slots forces us to configure the slot size depending on the
current stream configuration while just setting the ratio means
we can just fix the configuration once.  I'd say it's just a user
error to try to do both simultaneously.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)