linux-kernel - Re: [PATCH] drm: fix warnings in DSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Sep 2019 13:41:03 +0000
From:   Harry Wentland <hwentlan@....com>
To:     Benjamin Gaignard <benjamin.gaignard@...com>,
        "benjamin.gaignard@...aro.org" <benjamin.gaignard@...aro.org>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "manasi.d.navare@...el.com" <manasi.d.navare@...el.com>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: fix warnings in DSC

On 2019-09-11 4:47 a.m., Benjamin Gaignard wrote:
> Remove always false comparisons due to limited range of nfl_bpg_offset
> and scale_increment_interval fields.
> Warnings detected when compiling with W=1.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...com>

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>  drivers/gpu/drm/drm_dsc.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_dsc.c b/drivers/gpu/drm/drm_dsc.c
> index 77f4e5ae4197..27e5c6036658 100644
> --- a/drivers/gpu/drm/drm_dsc.c
> +++ b/drivers/gpu/drm/drm_dsc.c
> @@ -336,12 +336,6 @@ int drm_dsc_compute_rc_parameters(struct drm_dsc_config *vdsc_cfg)
>  	else
>  		vdsc_cfg->nfl_bpg_offset = 0;
>  
> -	/* 2^16 - 1 */
> -	if (vdsc_cfg->nfl_bpg_offset > 65535) {
> -		DRM_DEBUG_KMS("NflBpgOffset is too large for this slice height\n");
> -		return -ERANGE;
> -	}
> -
>  	/* Number of groups used to code the entire slice */
>  	groups_total = groups_per_line * vdsc_cfg->slice_height;
>  
> @@ -371,11 +365,6 @@ int drm_dsc_compute_rc_parameters(struct drm_dsc_config *vdsc_cfg)
>  		vdsc_cfg->scale_increment_interval = 0;
>  	}
>  
> -	if (vdsc_cfg->scale_increment_interval > 65535) {
> -		DRM_DEBUG_KMS("ScaleIncrementInterval is large for slice height\n");
> -		return -ERANGE;
> -	}
> -
>  	/*
>  	 * DSC spec mentions that bits_per_pixel specifies the target
>  	 * bits/pixel (bpp) rate that is used by the encoder,
>