linux-kernel - Re: [PATCH v4] Staging: exfat: avoid use of strcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <27939F0F-4406-4CAE-9D88-CFDA58A76BA1@volery.com>
Date:   Wed, 11 Sep 2019 21:16:21 +0200
From:   Sandro Volery <sandro@...ery.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     valdis.kletnieks@...edu, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        linux@...musvillemoes.dk
Subject: Re: [PATCH v4] Staging: exfat: avoid use of strcpy



> On 11 Sep 2019, at 21:06, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> 
> On Wed, Sep 11, 2019 at 09:53:03PM +0200, Sandro Volery wrote:
>> diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c
>> index da8c58149c35..4336fee444ce 100644
>> --- a/drivers/staging/exfat/exfat_core.c
>> +++ b/drivers/staging/exfat/exfat_core.c
>> @@ -2960,18 +2960,15 @@ s32 resolve_path(struct inode *inode, char *path, struct chain_t *p_dir,
>>    struct super_block *sb = inode->i_sb;
>>    struct fs_info_t *p_fs = &(EXFAT_SB(sb)->fs_info);
>>    struct file_id_t *fid = &(EXFAT_I(inode)->fid);
>> -
>> -    if (strlen(path) >= (MAX_NAME_LENGTH * MAX_CHARSET_SIZE))
>> +    
> 
> You have added a tab here.
> 
>> +    if (strscpy(name_buf, path, sizeof(name_buf)) < 0)
>>        return FFS_INVALIDPATH;
>> 
>> -    strcpy(name_buf, path);
>> -
>>    nls_cstring_to_uniname(sb, p_uniname, name_buf, &lossy);
>>    if (lossy)
>>        return FFS_INVALIDPATH;
>> 
>> -    fid->size = i_size_read(inode);
>> -
>> +fid->size = i_size_read(inode);
> 
> And you accidentally deleted some white space here.
> 
> I use vim, so I have it configured to highlight whitespace at the end of
> a line.  I don't remember how it's done now but I googled it for you.
> https://vim.fandom.com/wiki/Highlight_unwanted_spaces


Ugh I'm so sorry I make the most stupid mistakes today.. I was so sure 
this time I got it right!
I'll fix it tomorrow.

Thanks,
Sandro V