linux-kernel - Re: [PATCH 1/4] arm64: Kconfig: Fix XGENE driver dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190912010325.0DE5220863@mail.kernel.org>
Date:   Wed, 11 Sep 2019 18:03:24 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Amit Kucheria <amit.kucheria@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Mark Brown <broonie@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Sebastian Reichel <sre@...nel.org>,
        Will Deacon <will@...nel.org>, arm@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     linux-clk@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/4] arm64: Kconfig: Fix XGENE driver dependencies

Quoting Amit Kucheria (2019-09-11 15:18:45)
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 801fa1cd0321..9b2790d3f18a 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -225,7 +225,7 @@ config CLK_QORIQ
>  
>  config COMMON_CLK_XGENE
>         bool "Clock driver for APM XGene SoC"
> -       default ARCH_XGENE
> +       depends on ARCH_XGENE
>         depends on ARM64 || COMPILE_TEST

Is ARCH_XGENE supported outside of ARM64? I'd expect to see something
more like depends on ARCH_XGENE || COMPILE_TEST and default ARCH_XGENE
so that if the config is supported it becomes the default. Or at least
depends on ARCH_XGENE && ARM64 || COMPILE_TEST

>         ---help---
>           Sypport for the APM X-Gene SoC reference, PLL, and device clocks.