linux-kernel - Re: [PATCH 2/4] arm64: Kconfig: Fix BRCMSTB driver dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Sep 2019 11:20:40 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Amit Kucheria <amit.kucheria@...aro.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        arm-soc <arm@...nel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Mark Brown <broonie@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Sebastian Reichel <sre@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>, Will Deacon <will@...nel.org>,
        Linux PM list <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 2/4] arm64: Kconfig: Fix BRCMSTB driver dependencies

On Thu, Sep 12, 2019 at 12:19 AM Amit Kucheria <amit.kucheria@...aro.org> wrote:
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index 1851112ccc29..d80e8d70bf10 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -22,6 +22,7 @@ config ARM_CCI400_PORT_CTRL
>
>  config BRCMSTB_GISB_ARB
>         bool "Broadcom STB GISB bus arbiter"
> +       depends on ARCH_BRCMSTB
>         depends on ARM || ARM64 || MIPS
>         default ARCH_BRCMSTB || BMIPS_GENERIC
>         help

This breaks MIPS configurations that need this driver, and
it breask compile-testing on non-ARM/MIPS targets.

> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> index 651b763f80cd..6f0b1ed1a05a 100644
> --- a/drivers/power/reset/Kconfig
> +++ b/drivers/power/reset/Kconfig
> @@ -59,6 +59,7 @@ config POWER_RESET_BRCMKONA
>
>  config POWER_RESET_BRCMSTB
>         bool "Broadcom STB reset driver"
> +       depends on ARCH_BRCMSTB
>         depends on ARM || ARM64 || MIPS || COMPILE_TEST
>         depends on MFD_SYSCON
>         default ARCH_BRCMSTB || BMIPS_GENERIC

Same here and below.

> diff --git a/drivers/soc/bcm/Kconfig b/drivers/soc/bcm/Kconfig
> index 648e32693b7e..5a8ff33241ae 100644
> --- a/drivers/soc/bcm/Kconfig
> +++ b/drivers/soc/bcm/Kconfig
> @@ -24,6 +24,7 @@ config RASPBERRYPI_POWER
>
>  config SOC_BRCMSTB
>         bool "Broadcom STB SoC drivers"
> +       depends on ARCH_BRCMSTB
>         depends on ARM || ARM64 || BMIPS_GENERIC || COMPILE_TEST
>         select SOC_BUS
>         help

       Arnd