linux-kernel - Re: [PATCH] cpupower : Handle set and info subcommands for powerpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <17ce06dd-9baf-e0d1-df64-4b81787b2000@linux.vnet.ibm.com>
Date:   Thu, 12 Sep 2019 15:53:42 +0530
From:   Abhishek <huntbag@...ux.vnet.ibm.com>
To:     Thomas Renninger <trenn@...e.de>
Cc:     shuah <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org,
        "Gautham R. Shenoy" <ego@...ux.vnet.ibm.com>
Subject: Re: [PATCH] cpupower : Handle set and info subcommands for powerpc

Hi,


On 09/12/2019 03:46 PM, Thomas Renninger wrote:
> On Thursday, September 12, 2019 11:43:40 AM CEST Abhishek wrote:
>> Hi Shuah,
>>
>> Thanks for the review. Few comments below.
> ...
>
>> Since these two options are not being used by any other architecture
>> except x86, I suggest these options should not even be shown for
>> other architecture. So we can do something like this in cpupower.c :
>>
>> static struct cmd_struct commands[] = {
>>            .............
>> +#if defined (__x86_64__) || defined (__i386__)
>>           { "set",        cmd_set,        1    },
>>           { "info",        cmd_info,        0    },
>> +#endif
>>           ..............
>>
>> Is this Okay?
> No, I expected you to add something meaningful for Power case...

Haha. Will add something meaningful later...
(One of the suggestion has already been given by you)
>
> Just kidding. If this works without any side-effects in not x86 case, this
> approach seem to be the best solution for now.
>
> Thanks.
>
>    Thomas
>
>

-- Abhishek