linux-kernel - Re: [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXg1PDMBEd3S_pdk3KMG00Dq+xV6pCm_y6sXVR4aX1Wig@mail.gmail.com>
Date:   Thu, 12 Sep 2019 14:14:26 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
Cc:     Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Simon Horman <horms@...ge.net.au>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: renesas: r8a77970: Fix PWM3

On Thu, Sep 12, 2019 at 12:47 PM Kieran Bingham
<kieran.bingham+renesas@...asonboard.com> wrote:
> On 12/09/2019 11:31, Kieran Bingham wrote:
> > The pwm3 was incorrectly added with a compatible reference to the
> > renesas,pwm-r8a7790 (H2) due to a single characther ommision.
>
> Ugh, my apologies :
>
>  s/characther/character/
>  s/ommision/omission/
>
> Please fix up when applying if there's no need to send a v2.
>
> --
> Kieran
>
>
> >
> > Fix the compatible string.
> >
> > Fixes: de625477c632 ("arm64: dts: renesas: r8a779{7|8}0: add PWM support")
> > Signed-off-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
i.e. will queue in renesas-devel for v5.5, with the above fixed.

BTW, looks like PWM on R-Car Gen2 needs more love...

> > --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > @@ -652,7 +652,7 @@
> >               };
> >
> >               pwm3: pwm@...33000 {
> > -                     compatible = "renesas,pwm-r8a7790", "renesas,pwm-rcar";
> > +                     compatible = "renesas,pwm-r8a77970", "renesas,pwm-rcar";
> >                       reg = <0 0xe6e33000 0 8>;
> >                       #pwm-cells = <2>;
> >                       clocks = <&cpg CPG_MOD 523>;
> >

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds