linux-kernel - Re: Regression in 5.1.20: Reading long directory fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57185A91-0AC8-4805-B6CE-67D629F814C2@redhat.com>
Date:   Thu, 12 Sep 2019 09:08:51 -0400
From:   "Benjamin Coddington" <bcodding@...hat.com>
To:     "Trond Myklebust" <trondmy@...merspace.com>
Cc:     chuck.lever@...cle.com, tibbs@...h.uh.edu, bfields@...ldses.org,
        linux@...m.de, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org, km@...all.com
Subject: Re: Regression in 5.1.20: Reading long directory fails


On 12 Sep 2019, at 8:53, Trond Myklebust wrote:
> Let's please just scrap this function and rewrite it as a generic
> function for reading the MIC. It clearly is not a generic function for
> reading arbitrary netobjs, and modifications like the above just make
> the misnomer painfully obvious.
>
> Let's rewrite it as xdr_buf_read_mic() so that we can simplify it where
> possible.

Ok.  I want to assume the mic will not land in the head, but I am not sure..
Is there a scenario where the mic might land in the head, or is that bit of
the current function left over from other uses?

Ben