linux-kernel - Re: [PATCH v3 1/2] dt-bindings: backlight: lm3630a: add enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5c8d25ab-e780-4e60-9723-cd65553f4db3@ti.com>
Date:   Thu, 12 Sep 2019 10:03:12 -0500
From:   Dan Murphy <dmurphy@...com>
To:     Andreas Kemnade <andreas@...nade.info>
CC:     <lee.jones@...aro.org>, <daniel.thompson@...aro.org>,
        <jingoohan1@...il.com>, <jacek.anaszewski@...il.com>,
        <pavel@....cz>, <robh+dt@...nel.org>, <mark.rutland@....com>,
        <b.zolnierkie@...sung.com>, <dri-devel@...ts.freedesktop.org>,
        <linux-leds@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-fbdev@...r.kernel.org>,
        "H. Nikolaus Schaller" <hns@...delico.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: backlight: lm3630a: add enable_gpios

Andreas

On 9/12/19 9:58 AM, Andreas Kemnade wrote:
> On Thu, 12 Sep 2019 06:39:50 -0500
> Dan Murphy <dmurphy@...com> wrote:
>
>> Andreas
>>
>> On 9/11/19 12:21 PM, Andreas Kemnade wrote:
>>> add enable-gpios to describe HWEN pin
>>>
>>> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
>>> Acked-by: Daniel Thompson <daniel.thompson@...aro.org>
>>> ---
>>> changes in v2: added example
>>> changes in v3: added Acked-by
>>>    .../bindings/leds/backlight/lm3630a-backlight.yaml           | 5 +++++
>>>    1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>>> index dc129d9a329e..1fa83feffe16 100644
>>> --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>>> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>>> @@ -29,6 +29,10 @@ properties:
>>>      '#size-cells':
>>>        const: 0
>>>    
>>> +  enable-gpios:
>>> +    description: GPIO to use to enable/disable the backlight (HWEN pin).
>>> +    maxItems: 1
>>> +
>>>    required:
>>>      - compatible
>>>      - reg
>>> @@ -92,6 +96,7 @@ examples:
>>>        i2c {
>>>            #address-cells = <1>;
>>>            #size-cells = <0>;
>>> +        enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;
>>>    
>>>            led-controller@38 {
>>>                    compatible = "ti,lm3630a";
>> Looks good to me
>>
> well, the enable-gpios is still at the same place as in v2. This was sent
> before your comments to v2 have been arrived.

Ah I overlooked that.  Yeah that still needs to move I assumed you moved it.

Dan


> Regards,
> Andreas