linux-kernel - Re: [PATCH 1/2] watchdog: qcom: support pre-timeout when the bark irq is available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190912183435.GB5065@roeck-us.net>
Date:   Thu, 12 Sep 2019 11:34:35 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Jorge Ramirez-Ortiz, Linaro" <jorge.ramirez-ortiz@...aro.org>
Cc:     bjorn.andersson@...aro.org, wim@...ux-watchdog.org,
        agross@...nel.org, linux-arm-msm@...r.kernel.org,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] watchdog: qcom: support pre-timeout when the bark
 irq is available

On Thu, Sep 12, 2019 at 09:24:54AM +0200, Jorge Ramirez-Ortiz, Linaro wrote:
> On 10/09/19 11:06:55, Guenter Roeck wrote:
> > On Fri, Sep 06, 2019 at 10:54:10PM +0200, Jorge Ramirez-Ortiz wrote:
> > > Use the bark interrupt as the pre-timeout notifier whenever this
> > > interrupt is available.
> > > 
> > > By default, the pretimeout notification shall occur one second earlier
> > > than the timeout.
> > > 
> > > Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>
> > 
> > Nitpick below, otherwise:
> > 
> > Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> > 
> > > +		wdt->wdd.pretimeout = 0;
> > 
> > It is not necessary to set pretimeout to 0; the data structure was
> > allocated with devm_kzalloc(). The compiler won't know that and
> > generate unnecessary code otherwise.
> 
> will you need me to send another version or could you pick it up as is?
> 

I applied the patch to my watchdog-next branch, with the line removed.
Let's assume that Wim will pick it up from there. If not, and
the line stays in, no real damage.

In short, no need to resubmit.

Guenter