linux-kernel - [PATCH] checkpatch.pl: Don't complain about nominal authors if there isn't one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1909121651180.1305-100000@iolanthe.rowland.org>
Date:   Thu, 12 Sep 2019 16:55:15 -0400 (EDT)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>
cc:     Kernel development list <linux-kernel@...r.kernel.org>
Subject: [PATCH] checkpatch.pl: Don't complain about nominal authors if there
 isn't one

checkpatch.pl shouldn't warn about a "Missing Signed-off-by: line by
nominal patch author" if there is no nominal patch author.  Without
this change, checkpatch always gives me the following warning:

	WARNING: Missing Signed-off-by: line by nominal patch author ''

Signed-off-by: Alan Stern <stern@...land.harvard.edu>

---

 scripts/checkpatch.pl |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: usb-devel/scripts/checkpatch.pl
===================================================================
--- usb-devel.orig/scripts/checkpatch.pl
+++ usb-devel/scripts/checkpatch.pl
@@ -6673,7 +6673,7 @@ sub process {
 		if ($signoff == 0) {
 			ERROR("MISSING_SIGN_OFF",
 			      "Missing Signed-off-by: line(s)\n");
-		} elsif (!$authorsignoff) {
+		} elsif ($author ne '' && !$authorsignoff) {
 			WARN("NO_AUTHOR_SIGN_OFF",
 			     "Missing Signed-off-by: line by nominal patch author '$author'\n");
 		}