linux-kernel - Re: [PATCH v2 1/4] null_blk: do not fail the module load with zero devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB5749CB3F25FC6F18C48C58F986B30@BYAPR04MB5749.namprd04.prod.outlook.com>
Date:   Fri, 13 Sep 2019 22:15:07 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     André Almeida <andrealmeid@...labora.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "corbet@....net" <corbet@....net>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "kernel@...labora.com" <kernel@...labora.com>,
        "krisman@...labora.com" <krisman@...labora.com>
Subject: Re: [PATCH v2 1/4] null_blk: do not fail the module load with zero
 devices

Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>

On 09/13/2019 03:04 PM, André Almeida wrote:
> The module load should fail only if there is something wrong with the
> configuration or if an error prevents it to work properly. The module
> should be able to be loaded with (nr_device == 0), since it will not
> trigger errors or be in malfunction state. Preventing loading with zero
> devices also breaks applications that configures this module using
> configfs API. Remove the nr_device check to fix this.
>
> Signed-off-by: André Almeida <andrealmeid@...labora.com>
> Fixes: f7c4ce890dd2 ("null_blk: validate the number of devices")
> ---
> Changes since v1:
> - None
> ---
>   drivers/block/null_blk_main.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/block/null_blk_main.c b/drivers/block/null_blk_main.c
> index ab4b87677139..be32cb5ed339 100644
> --- a/drivers/block/null_blk_main.c
> +++ b/drivers/block/null_blk_main.c
> @@ -1758,10 +1758,6 @@ static int __init null_init(void)
>   		pr_err("null_blk: legacy IO path no longer available\n");
>   		return -EINVAL;
>   	}
> -	if (!nr_devices) {
> -		pr_err("null_blk: invalid number of devices\n");
> -		return -EINVAL;
> -	}
>   	if (g_queue_mode == NULL_Q_MQ && g_use_per_node_hctx) {
>   		if (g_submit_queues != nr_online_nodes) {
>   			pr_warn("null_blk: submit_queues param is set to %u.\n",
>