linux-kernel - Re: [PATCH v2 4/4] coding-style: add explanation about pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB57491969A325583BDDBC7DA486B30@BYAPR04MB5749.namprd04.prod.outlook.com>
Date:   Fri, 13 Sep 2019 22:18:04 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     André Almeida <andrealmeid@...labora.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "corbet@....net" <corbet@....net>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "kernel@...labora.com" <kernel@...labora.com>,
        "krisman@...labora.com" <krisman@...labora.com>
Subject: Re: [PATCH v2 4/4] coding-style: add explanation about pr_fmt macro

I'm not super familier with the format, will let someone do the
final review.

In general looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@....com>

On 09/13/2019 03:04 PM, André Almeida wrote:
> The pr_fmt macro is useful to format log messages printed by pr_XXXX()
> functions. Add text to explain the purpose of it, how to use and an
> example.
>
> Signed-off-by: André Almeida<andrealmeid@...labora.com>
> Cc: Jonathan Corbet<corbet@....net>
> ---
> Changes from v1:
> - Add Jonathan as explict Cc
> - Replace "include/printk.h" by "#include <linux/kernel.h>
> - Add note about #undef
> - Replace hardcore string by KBUILD_MODNAME at the example
> ---