linux-kernel - Re: [RFC] Improve memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Sep 2019 12:42:32 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Rasmus Villemoes <mail@...musvillemoes.dk>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        x86-ml <x86@...nel.org>, Andy Lutomirski <luto@...nel.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: [RFC] Improve memset

On Fri, Sep 13, 2019 at 11:18:00AM +0200, Rasmus Villemoes wrote:
> Something like
> 
> 	if (__builtin_constant_p(c) && __builtin_constant_p(n) && n <= 32)
> 		return __builtin_memset(dest, c, n);
> 
> might be enough? Of course it would be sad if 32 was so high that this
> turned into a memset() call, but there's -mmemset-strategy= if one wants
> complete control. Though that's of course build-time, so can't consider
> differences between cpu models.

Yah, that seems to turn this:

        memset(&tr, 0, sizeof(tr));
        tr.b            = b;

where sizeof(tr) < 32 into:

# ./arch/x86/include/asm/string_64.h:29:                return __builtin_memset(dest, c, n);
        movq    $0, 16(%rsp)    #, MEM[(void *)&tr + 8B]
        movq    $0, 24(%rsp)    #, MEM[(void *)&tr + 8B]
# arch/x86/kernel/cpu/mce/amd.c:1070:   tr.b            = b;
        movq    %rbx, 8(%rsp)   # b, tr.b

which is 2 u64 moves and the assignment of b at offset 8.

Question is, where we should put the size cap? I'm thinking 32 or 64
bytes...

Linus, got any suggestions?

Or should we talk to Intel hw folks about it...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette