linux-kernel - Re: [PATCH v2] tracing: Be more clever when dumping hex in __print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190913122826.GP2680@smile.fi.intel.com>
Date:   Fri, 13 Sep 2019 15:28:26 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH v2] tracing: Be more clever when dumping hex in
 __print_hex()

On Tue, Aug 06, 2019 at 11:33:52AM -0400, Steven Rostedt wrote:
> On Tue,  6 Aug 2019 18:15:43 +0300
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> 
> > Hex dump as many as 16 bytes at once in trace_print_hex_seq()
> > instead of byte-by-byte approach.

> > +	const char *fmt = concatenate ? "%*phN" : "%*ph";
> >  
> > +	for (i = 0; i < buf_len; i += 16)
> > +		trace_seq_printf(p, fmt, min(buf_len - i, 16), &buf[i]);
> 
> Cute.
> 
> I'll have to wrap my head around it a bit to make sure it's correct.

Anything I need to update here?

-- 
With Best Regards,
Andy Shevchenko