linux-kernel - Re: Regression: commit c9712e333809 breaks xilinx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 13 Sep 2019 08:03:37 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Paul Thomas <pthomas8589@...il.com>,
        Michal Simek <michal.simek@...inx.com>
Cc:     Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
        Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sasha Levin <sashal@...nel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Regression: commit c9712e333809 breaks xilinx_uartps

On 12. 09. 19 18:38, Paul Thomas wrote:
>>> ---
>>>  drivers/tty/serial/xilinx_uartps.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/tty/serial/xilinx_uartps.c
>>> b/drivers/tty/serial/xilinx_uartps.c
>>> index 9dcc4d855ddd..ece7f6caa994 100644
>>> --- a/drivers/tty/serial/xilinx_uartps.c
>>> +++ b/drivers/tty/serial/xilinx_uartps.c
>>> @@ -1565,6 +1565,8 @@ static int cdns_uart_probe(struct platform_device *pdev)
>>>
>>>         cdns_uart_data->pclk = devm_clk_get(&pdev->dev, "pclk");
>>>         if (PTR_ERR(cdns_uart_data->pclk) == -EPROBE_DEFER) {
>>> +               /* If we end up defering then set uartps_major back to 0 */
>>> +               uartps_major = 0;
>>>                 rc = PTR_ERR(cdns_uart_data->pclk);
>>>                 goto err_out_unregister_driver;
>>>         }
>>>
>>
>> I expect that this can be problematic for all failures in probe.
>> What about this?
> Makes sense, this worked for me. Although, I think the patch is
> malformed by the email line lengths.

I just c&p. Let me send proper patch with description.

Thanks,
Michal