linux-kernel - Re: [PATCH 1/3] brcmsmac: Remove unneeded variable and make function to be void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Sep 2019 13:37:52 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     <davem@...emloft.net>, <zhongjiang@...wei.com>,
        <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] brcmsmac: Remove unneeded variable and make function
 to be void

zhong jiang <zhongjiang@...wei.com> wrote:

> brcms_c_set_mac  do not need return value to cope with different
> cases. And change functon return type to void.
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>

I just don't see the benefit from changing the function to return void.
And if we ever add error handling to the function we need to change it
back to return int again, which is extra work.

Patch set to Rejected.

-- 
https://patchwork.kernel.org/patch/11143403/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches