[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190913105446.2b7af558@coco.lan>
Date: Fri, 13 Sep 2019 10:54:46 -0300
From: Mauro Carvalho Chehab <mchehab@...nel.org>
To: Matthew Wilcox <willy6545@...il.com>
Cc: Bart Van Assche <bvanassche@....org>,
Joe Perches <joe@...ches.com>,
"Martin K . Petersen" <martin.petersen@...cle.com>,
Dan Williams <dan.j.williams@...el.com>,
Dave Jiang <dave.jiang@...el.com>,
ksummit-discuss@...ts.linuxfoundation.org,
linux-nvdimm@...ts.01.org,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-kernel@...r.kernel.org,
Steve French <stfrench@...rosoft.com>,
Vishal Verma <vishal.l.verma@...el.com>,
Dmitry Vyukov <dvyukov@...gle.com>,
"Tobin C. Harding" <me@...in.cc>
Subject: Re: [Ksummit-discuss] [PATCH v2 0/3] Maintainer Entry Profiles
Em Fri, 13 Sep 2019 08:56:30 -0400
Matthew Wilcox <willy6545@...il.com> escreveu:
> It's easy enough to move the kernel-doc warnings out from under W=1. I only
> out them there to avoid overwhelming us with new warnings. If they're
> mostly fixed now, let's make checking them the default.
Didn't try doing it kernelwide, but for media we do use W=1 by default,
on our CI instance.
There's a few warnings at EDAC, but they all seem easy enough to be
fixed.
So, from my side, I'm all to make W=1 default.
Regards,
Mauro
>
> On Thu., Sep. 12, 2019, 16:01 Bart Van Assche, <bvanassche@....org> wrote:
>
> > On 9/12/19 8:34 AM, Joe Perches wrote:
> > > On Thu, 2019-09-12 at 14:31 +0100, Bart Van Assche wrote:
> > >> On 9/11/19 5:40 PM, Martin K. Petersen wrote:
> > >>> * The patch must compile without warnings (make C=1
> > CF="-D__CHECK_ENDIAN__")
> > >>> and does not incur any zeroday test robot complaints.
> > >>
> > >> How about adding W=1 to that make command?
> > >
> > > That's rather too compiler version dependent and new
> > > warnings frequently get introduced by new compiler versions.
> >
> > I've never observed this myself. If a new compiler warning is added to
> > gcc and if it produces warnings that are not useful for kernel code
> > usually Linus or someone else is quick to suppress that warning.
> >
> > Another argument in favor of W=1 is that the formatting of kernel-doc
> > headers is checked only if W=1 is passed to make.
> >
> > Bart.
> >
> > _______________________________________________
> > Ksummit-discuss mailing list
> > Ksummit-discuss@...ts.linuxfoundation.org
> > https://lists.linuxfoundation.org/mailman/listinfo/ksummit-discuss
> >
Thanks,
Mauro
Powered by blists - more mailing lists