linux-kernel - Re: [RFC PATCH 3/7] drm/ttm: TTM fault handler helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <f26f6096-8d11-82e4-390c-d110af8fdc49@shipmail.org>
Date:   Fri, 13 Sep 2019 16:34:02 +0200
From:   Thomas Hellström (VMware) 
        <thomas_os@...pmail.org>
To:     Hillf Danton <hdanton@...a.com>,
        Thomas Hellstrom <thellstrom@...are.com>
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-mm@...ck.org, pv-drivers@...are.com,
        linux-graphics-maintainer@...are.com,
        Andrew Morton <akpm@...ux-foundation.org>,
        Matthew Wilcox <willy@...radead.org>,
        Will Deacon <will.deacon@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Rik van Riel <riel@...riel.com>,
        Minchan Kim <minchan@...nel.org>,
        Michal Hocko <mhocko@...e.com>,
        Huang Ying <ying.huang@...el.com>,
        Souptick Joarder <jrdr.linux@...il.com>, jglisse@...hat.com,
        christian.koenig@....com, Christoph Hellwig <hch@...radead.org>
Subject: Re: [RFC PATCH 3/7] drm/ttm: TTM fault handler helpers

On 9/13/19 3:40 PM, Hillf Danton wrote:
> On Fri, 13 Sep 2019 11:32:09 +0200
>>   	err = ttm_mem_io_lock(man, true);
>> -	if (unlikely(err != 0)) {
>> -		ret = VM_FAULT_NOPAGE;
>> -		goto out_unlock;
>> -	}
>> +	if (unlikely(err != 0))
>> +		return VM_FAULT_NOPAGE;
>>   	err = ttm_mem_io_reserve_vm(bo);
>> -	if (unlikely(err != 0)) {
>> -		ret = VM_FAULT_SIGBUS;
>> -		goto out_io_unlock;
>> -	}
>> +	if (unlikely(err != 0))
>> +		return VM_FAULT_SIGBUS;
>>
> Hehe, no hurry.

Could you be a bit more specific?

Thanks,

Thomas



>
>> @@ -295,8 +307,28 @@ static vm_fault_t ttm_bo_vm_fault(struct vm_fault *vmf)
>>   	ret = VM_FAULT_NOPAGE;
>>   out_io_unlock:
>>   	ttm_mem_io_unlock(man);
>> -out_unlock:
>> +	return ret;
>> +}
>> +EXPORT_SYMBOL(ttm_bo_vm_fault_reserved);