linux-kernel - Re: [PATCH 0/7] Address most issues when building with W=1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190913175320.GD4190@zn.tnic>
Date:   Fri, 13 Sep 2019 19:53:20 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Cc:     Linux Edac Mailing List <linux-edac@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Tony Luck <tony.luck@...el.com>,
        Qiuxu Zhuo <qiuxu.zhuo@...el.com>,
        Robert Richter <rrichter@...vell.com>,
        James Morse <james.morse@....com>,
        Khuong Dinh <khuong@...amperecomputing.com>
Subject: Re: [PATCH 0/7] Address most issues when building with W=1

On Fri, Sep 13, 2019 at 11:50:25AM -0300, Mauro Carvalho Chehab wrote:
> There is a recent discussion at KS ML with regards to use W=1 as default.
> 
> No idea if this will happen or not, but it doesn't hurt cleaning up W=1
> warnings from the EDAC subsystem, specially since it helps to cleanup
> a few things.
> 
> This patch series addresses most of such warnings.  After this series,
> there will be just two W=1 warnings:
> 
> 1) i5100 EDAC driver:
> 
> 	drivers/edac/i5100_edac.c: In function ‘i5100_read_log’:
> 	drivers/edac/i5100_edac.c:487:11: warning: variable ‘ecc_loc’ set but not used [-Wunused-but-set-variable]
> 	  487 |  unsigned ecc_loc = 0;
> 	      |           ^~~~~~~
> 
> 
>    The ecc_loc contents is filled from MC data, but it is not used anywere.
>    The i5100 MC is very old: the affected code was added in 2008. It should
>    probably be safe to just drop the corresponding data, but, as it may
>    contain some relevant info, I was a little reticent of doing that.
> 
> 2) Xgene EDAC driver:
> 
> 	drivers/edac/xgene_edac.c: In function ‘xgene_edac_rb_report’:
> 	drivers/edac/xgene_edac.c:1486:7: warning: variable ‘address’ set but not used [-Wunused-but-set-variable]
> 	 1486 |   u32 address;
> 	      |       ^~~~~~~
> 
>    I suspect that the content of the address field should actually be used on
>    at least some of the logs.

+ Khuong Dinh <khuong@...amperecomputing.com> for that.

> I may eventually submit patches later to address the above cases, but let's
> solve first the other cases, as they all sound trivial enough.
> 
> Mauro Carvalho Chehab (7):
>   EDAC: i5100_edac: get rid of an unused var
>   EDAC: i7300_edac: rename a kernel-doc var description
>   EDAC: i7300_edac: fix a kernel-doc syntax
>   EDAC: i5400_edac: print type at debug message
>   EDAC: i5400_edac: get rid of some unused vars
>   EDAC: sb_edac: get rid of unused vars
>   EDAC: skx_common: get rid of unused type var
> 
>  drivers/edac/i5100_edac.c |  2 --
>  drivers/edac/i5400_edac.c | 15 +++------------
>  drivers/edac/i7300_edac.c |  4 ++--
>  drivers/edac/sb_edac.c    | 21 ++++++++-------------
>  drivers/edac/skx_common.c |  5 +----
>  5 files changed, 14 insertions(+), 33 deletions(-)

Looks ok to me at a quick glance, ACK.

I've already sent the 5.4 pull request to Linus so you could queue those
after -rc1. It's not like they're urgent or so.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette