[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <FFDFD18F-C242-46D2-B64B-5515987AD82D@kernel.dk>
Date: Fri, 13 Sep 2019 12:03:34 -0700
From: Jens Axboe <axboe@...nel.dk>
To: André Almeida <andrealmeid@...labora.com>
Cc: linux-block@...r.kernel.org, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, corbet@....net, kernel@...labora.com,
krisman@...labora.com
Subject: Re: [PATCH 0/4] null_blk: fixes around nr_devices and log improvements
On Sep 13, 2019, at 11:58 AM, André Almeida <andrealmeid@...labora.com> wrote:
>
> Hello,
>
> This patch series address feedback for a previous patch series sent by
> me "docs: block: null_blk: enhance document style"[1].
>
> First patch removes a restriction that prevents null_blk to load with
> (nr_devices == 0). This restriction breaks applications, so it's a bug. I
> have tested it running the kernel with `null_blk.nr_devices=0`.
>
> In the previous series I have changed the type of var nr_devices, but I
> forgot to change the type at module_param(). The second patch fix that.
>
> The third patch uses a cleaver approach to make log messages consistent
> using pr_fmt and the last one add a note on how to do that at the
> coding style documentation.
Please add Fixes tags to your patches.
Powered by blists - more mailing lists