linux-kernel - Re: [PATCH v2 24/27] drm/amdgpu/dm: Resume short HPD IRQs before resuming MST topology

Open Source and information security mailing list archives

Date:   Fri, 13 Sep 2019 16:46:12 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Lyude Paul <lyude@...hat.com>
Cc:     Maling list - DRI developers <dri-devel@...ts.freedesktop.org>,
        nouveau <nouveau@...ts.freedesktop.org>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Leo Li <sunpeng.li@....com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        LKML <linux-kernel@...r.kernel.org>,
        Nicholas Kazlauskas <nicholas.kazlauskas@....com>,
        Bhawanpreet Lakha <Bhawanpreet.Lakha@....com>,
        David Airlie <airlied@...ux.ie>,
        Juston Li <juston.li@...el.com>,
        Alex Deucher <alexander.deucher@....com>,
        David Francis <David.Francis@....com>,
        Harry Wentland <hwentlan@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH v2 24/27] drm/amdgpu/dm: Resume short HPD IRQs before
 resuming MST topology

On Tue, Sep 3, 2019 at 4:49 PM Lyude Paul <lyude@...hat.com> wrote:
>
> Since we're going to be reprobing the entire topology state on resume
> now using sideband transactions, we need to ensure that we actually have
> short HPD irqs enabled before calling drm_dp_mst_topology_mgr_resume().
> So, do that.
>
> Cc: Juston Li <juston.li@...el.com>
> Cc: Imre Deak <imre.deak@...el.com>
> Cc: Ville Syrjälä <ville.syrjala@...ux.intel.com>
> Cc: Harry Wentland <hwentlan@....com>
> Cc: Daniel Vetter <daniel.vetter@...ll.ch>
> Signed-off-by: Lyude Paul <lyude@...hat.com>

Acked-by: Alex Deucher <alexander.deucher@....com>

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 73630e2940d4..4d3c8bff77da 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1185,15 +1185,15 @@ static int dm_resume(void *handle)
>         /* program HPD filter */
>         dc_resume(dm->dc);
>
> -       /* On resume we need to  rewrite the MSTM control bits to enamble MST*/
> -       s3_handle_mst(ddev, false);
> -
>         /*
>          * early enable HPD Rx IRQ, should be done before set mode as short
>          * pulse interrupts are used for MST
>          */
>         amdgpu_dm_irq_resume_early(adev);
>
> +       /* On resume we need to  rewrite the MSTM control bits to enamble MST*/
> +       s3_handle_mst(ddev, false);
> +
>         /* Do detection*/
>         drm_connector_list_iter_begin(ddev, &iter);
>         drm_for_each_connector_iter(connector, &iter) {
> --
> 2.21.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives