linux-kernel - Re: [PATCH] mm: remove redundant assignment of entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190914000326.h4ruqmyvo3yisf52@master>
Date:   Sat, 14 Sep 2019 00:03:26 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     Wei Yang <richardw.yang@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        willy@...radead.org, will@...nel.org, peterz@...radead.org
Subject: Re: [PATCH] mm: remove redundant assignment of entry

On Mon, Jul 08, 2019 at 04:27:40PM +0800, Wei Yang wrote:
>Since ptent will not be changed after previous assignment of entry, it
>is not necessary to do the assignment again.
>

Sounds this one is lost in the time line :-)

>Signed-off-by: Wei Yang <richardw.yang@...ux.intel.com>
>---
> mm/memory.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/mm/memory.c b/mm/memory.c
>index ddf20bd0c317..d108bb979a08 100644
>--- a/mm/memory.c
>+++ b/mm/memory.c
>@@ -1127,7 +1127,6 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
> 		if (unlikely(details))
> 			continue;
> 
>-		entry = pte_to_swp_entry(ptent);
> 		if (!non_swap_entry(entry))
> 			rss[MM_SWAPENTS]--;
> 		else if (is_migration_entry(entry)) {
>-- 
>2.17.1

-- 
Wei Yang
Help you, Help me