linux-kernel - Re: [PATCH 4/4] x86: fix function types in COND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E577F06C-C48E-4633-9D9D-4535B315D304@amacapital.net>
Date:   Fri, 13 Sep 2019 17:28:51 -0700
From:   Andy Lutomirski <luto@...capital.net>
To:     Sami Tolvanen <samitolvanen@...gle.com>
Cc:     Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H . Peter Anvin" <hpa@...or.com>,
        Kees Cook <keescook@...omium.org>, X86 ML <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/4] x86: fix function types in COND_SYSCALL



> On Sep 13, 2019, at 4:28 PM, Sami Tolvanen <samitolvanen@...gle.com> wrote:
> 
>> On Fri, Sep 13, 2019 at 3:46 PM Andy Lutomirski <luto@...nel.org> wrote:
>> Didn't you just fix the type of sys_ni_syscall?  What am I missing here?
> 
> The other patch fixes indirect call type mismatches when the function
> is called through the syscall table. However, cond_syscall creates an
> alias to the actual sys_ni_syscall function defined in
> kernel/sys_ni.c, which still has the wrong type.
> 

Ah, I get it. Doesn’t this cause a little bit of code bloat, though?  What if you made __x86_ni_syscall, etc (possibly using the *DEFINE_SYSCALL0 macros) and then generate weak aliases to those?