linux-kernel - Re: [PATCH v2] net: stmmac: socfpga: re-use the `interface` parameter from platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190915.195149.86866545205816280.davem@davemloft.net>
Date:   Sun, 15 Sep 2019 19:51:49 +0100 (WEST)
From:   David Miller <davem@...emloft.net>
To:     alexandru.ardelean@...log.com
Cc:     netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        peppe.cavallaro@...com, alexandre.torgue@...com,
        joabreu@...opsys.com, mcoquelin.stm32@...il.com
Subject: Re: [PATCH v2] net: stmmac: socfpga: re-use the `interface`
 parameter from platform data

From: Alexandru Ardelean <alexandru.ardelean@...log.com>
Date: Thu, 12 Sep 2019 16:28:50 +0300

> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> index c141fe783e87..5b6213207c43 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c
 ...
> +static inline int socfpga_get_plat_phymode(struct socfpga_dwmac *dwmac)

Please do not use the inline keyword in foo.c files, let the compiler device.