linux-kernel - Re: [RESEND v4 1/7] mm, slab: Make kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1909151410250.211705@chino.kir.corp.google.com>
Date:   Sun, 15 Sep 2019 14:38:26 -0700 (PDT)
From:   David Rientjes <rientjes@...gle.com>
To:     Pengfei Li <lpf.vector@...il.com>
cc:     akpm@...ux-foundation.org, vbabka@...e.cz, cl@...ux.com,
        penberg@...nel.org, iamjoonsoo.kim@....com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, guro@...com
Subject: Re: [RESEND v4 1/7] mm, slab: Make kmalloc_info[] contain all types
 of names

On Mon, 16 Sep 2019, Pengfei Li wrote:

> There are three types of kmalloc, KMALLOC_NORMAL, KMALLOC_RECLAIM
> and KMALLOC_DMA.
> 
> The name of KMALLOC_NORMAL is contained in kmalloc_info[].name,
> but the names of KMALLOC_RECLAIM and KMALLOC_DMA are dynamically
> generated by kmalloc_cache_name().
> 
> This patch predefines the names of all types of kmalloc to save
> the time spent dynamically generating names.
> 
> Besides, remove the kmalloc_cache_name() that is no longer used.
> 
> Signed-off-by: Pengfei Li <lpf.vector@...il.com>
> Acked-by: Vlastimil Babka <vbabka@...e.cz>
> Acked-by: Roman Gushchin <guro@...com>

Acked-by: David Rientjes <rientjes@...gle.com>

It's unfortunate the existing names are kmalloc-, dma-kmalloc-, and 
kmalloc-rcl- since they aren't following any standard naming convention.

Also not sure I understand the SET_KMALLOC_SIZE naming since this isn't 
just setting a size.  Maybe better off as INIT_KMALLOC_INFO?

Nothing major though, so:

Acked-by: David Rientjes <rientjes@...gle.com>