linux-kernel - Re: [PATCHv2 0/7] Non-urgent fixes and improvments for omap3-rom-rng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Sep 2019 09:47:03 +0300
From:   Tero Kristo <t-kristo@...com>
To:     Tony Lindgren <tony@...mide.com>, Matt Mackall <mpm@...enic.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        <linux-kernel@...r.kernel.org>, <linux-omap@...r.kernel.org>
CC:     <linux-crypto@...r.kernel.org>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Adam Ford <aford173@...il.com>,
        Pali Rohár <pali.rohar@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Sebastian Reichel <sre@...nel.org>,
        <devicetree@...r.kernel.org>
Subject: Re: [PATCHv2 0/7] Non-urgent fixes and improvments for omap3-rom-rng

On 15/09/2019 00:02, Tony Lindgren wrote:
> Hi all,
> 
> Here are fixes and improvments for omap3-rom-rng that's been broken for
> a while.
> 
> The first four patches get it working, and then the last two patches add
> support for runtime PM.
> 
> I did not add Sebastian's acks from v1 set as many of the patches
> changed. Please review again :)

Series looks fine to me also, don't have possibility to test omap3 ROM 
RNG though (don't have HW for this.) For the whole series:

Reviewed-by: Tero Kristo <t-kristo@...com>



> Regards,
> 
> Tony
> 
> Changes since v1:
> - Use clk_prepare_enable() as pointed out by Sebastian
> - Simplify runtime PM changes patch
> - Add a new patch for devm changes as suggested by Sebastian
> 
> 
> Tony Lindgren (7):
>    ARM: OMAP2+: Check omap3-rom-rng for GP device instead of HS device
>    hwrng: omap3-rom - Fix missing clock by probing with device tree
>    hwrng: omap3-rom - Call clk_disable_unprepare() on exit only if not
>      idled
>    hwrng: omap3-rom - Initialize default quality to get data
>    hwrng: omap3-rom - Update to use standard driver data
>    hwrng: omap3-rom - Use runtime PM instead of custom functions
>    hwrng: omap3-rom - Use devm hwrng and runtime PM
> 
>   .../devicetree/bindings/rng/omap3_rom_rng.txt |  27 +++
>   arch/arm/boot/dts/omap3-n900.dts              |   6 +
>   arch/arm/mach-omap2/pdata-quirks.c            |  14 +-
>   drivers/char/hw_random/omap3-rom-rng.c        | 168 +++++++++++-------
>   4 files changed, 139 insertions(+), 76 deletions(-)
>   create mode 100644 Documentation/devicetree/bindings/rng/omap3_rom_rng.txt
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki