linux-kernel - RE: [PATCH v3 08/11] PCI: layerscape: Modify the MSIX to the doorbell mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR12MB4010DE94A68B6BA4E132DF8CDA8C0@DM6PR12MB4010.namprd12.prod.outlook.com>
Date:   Mon, 16 Sep 2019 08:54:08 +0000
From:   Gustavo Pimentel <Gustavo.Pimentel@...opsys.com>
To:     Xiaowei Bao <xiaowei.bao@....com>,
        Gustavo Pimentel <Gustavo.Pimentel@...opsys.com>,
        Andrew Murray <andrew.murray@....com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        Leo Li <leoyang.li@....com>, "kishon@...com" <kishon@...com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "M.h. Lian" <minghuan.lian@....com>,
        Mingkai Hu <mingkai.hu@....com>, Roy Zang <roy.zang@....com>,
        "jingoohan1@...il.com" <jingoohan1@...il.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Z.q. Hou" <zhiqiang.hou@....com>
Subject: RE: [PATCH v3 08/11] PCI: layerscape: Modify the MSIX to the doorbell
 mode

On Sat, Sep 14, 2019 at 7:37:54, Xiaowei Bao <xiaowei.bao@....com> wrote:

> 
> 
> > -----Original Message-----
> > From: Gustavo Pimentel <Gustavo.Pimentel@...opsys.com>
> > Sent: 2019年9月12日 19:24
> > To: Andrew Murray <andrew.murray@....com>; Xiaowei Bao
> > <xiaowei.bao@....com>
> > Cc: robh+dt@...nel.org; mark.rutland@....com; shawnguo@...nel.org; Leo
> > Li <leoyang.li@....com>; kishon@...com; lorenzo.pieralisi@....com; M.h.
> > Lian <minghuan.lian@....com>; Mingkai Hu <mingkai.hu@....com>; Roy
> > Zang <roy.zang@....com>; jingoohan1@...il.com;
> > gustavo.pimentel@...opsys.com; linux-pci@...r.kernel.org;
> > devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> > linux-arm-kernel@...ts.infradead.org; linuxppc-dev@...ts.ozlabs.org;
> > arnd@...db.de; gregkh@...uxfoundation.org; Z.q. Hou
> > <zhiqiang.hou@....com>
> > Subject: RE: [PATCH v3 08/11] PCI: layerscape: Modify the MSIX to the
> > doorbell mode
> > 
> > Hi,
> > 
> > Sorry for the delay I was in parental leave and I'm still trying not to drown in
> > the mailing list emails... 😊
> > 
> > On Mon, Sep 2, 2019 at 13:1:47, Andrew Murray <andrew.murray@....com>
> > wrote:
> > 
> > > On Mon, Sep 02, 2019 at 11:17:13AM +0800, Xiaowei Bao wrote:
> > > > dw_pcie_ep_raise_msix_irq was never called in the exisitng driver
> > > > before, because the ls1046a platform don't support the MSIX feature
> > > > and msix_capable was always set to false.
> > > > Now that add the ls1088a platform with MSIX support, but the
> > > > existing dw_pcie_ep_raise_msix_irq doesn't work, so use the doorbell
> > > > method to support the MSIX feature.
> > 
> > Hum... the implementation of msix implementation did work on my use case,
> > however, at the time the setup used for developing and testing the
> > implementation only had one PF (by default 0). Perhaps this could was is
> > causing the different behavior between our setups.
> > 
> > You have more than one PF, right?
> 
> Yes, I have two PFs.

Probably that's the reason why my MSI-X raise function implementation 
didn't work on your case.

> 
> Thanks
> Xiaowei
> 
> > 
> > If I remember correctly, msix feature support entered on kernel 4.19 version
> > and it worked quite well at the time, but I didn't test since there (I've to
> > manage time to be able to retest it again), I'm didn't seen any patch that
> > could interfere with this.
> > 
> > Regards,
> > Gustavo
> > 
> > 
> > > >
> > > > Signed-off-by: Xiaowei Bao <xiaowei.bao@....com>
> > >
> > > Reviewed-by: Andrew Murray <andrew.murray@....com>
> > >
> > > > ---
> > > > v2:
> > > >  - No change
> > > > v3:
> > > >  - Modify the commit message make it clearly.
> > > >
> > > >  drivers/pci/controller/dwc/pci-layerscape-ep.c | 3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > > > b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > > > index 1e07287..5f0cb99 100644
> > > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > > > @@ -79,7 +79,8 @@ static int ls_pcie_ep_raise_irq(struct dw_pcie_ep
> > *ep, u8 func_no,
> > > >  	case PCI_EPC_IRQ_MSI:
> > > >  		return dw_pcie_ep_raise_msi_irq(ep, func_no, interrupt_num);
> > > >  	case PCI_EPC_IRQ_MSIX:
> > > > -		return dw_pcie_ep_raise_msix_irq(ep, func_no, interrupt_num);
> > > > +		return dw_pcie_ep_raise_msix_irq_doorbell(ep, func_no,
> > > > +							  interrupt_num);
> > > >  	default:
> > > >  		dev_err(pci->dev, "UNKNOWN IRQ type\n");
> > > >  		return -EINVAL;
> > > > --
> > > > 2.9.5
> > > >
> >