linux-kernel - Re: [PATCH] sched/rt: silence double clock update warning by using rq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f388725d-1725-401f-bb44-9bcc785a124a@arm.com>
Date:   Mon, 16 Sep 2019 09:56:46 +0100
From:   Valentin Schneider <valentin.schneider@....com>
To:     Phil Auld <pauld@...hat.com>, linux-kernel@...r.kernel.org
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] sched/rt: silence double clock update warning by using
 rq_lock wrappers

[Added Steven to Cc]

On 15/08/2019 18:24, Valentin Schneider wrote:
> On 15/08/2019 15:53, Phil Auld wrote:
>> With WARN_DOUBLE_CLOCK enabled a false positive warning can occur in rt
>>
>>         [] rq->clock_update_flags & RQCF_UPDATED
>>         [] WARNING: CPU: 6 PID: 21426 at kernel/sched/core.c:225 
>> 						update_rq_clock+0x90/0x130
>>           [] Call Trace:
>>           []  update_rq_clock+0x90/0x130
>>           []  sched_rt_period_timer+0x11f/0x340
>>           []  __hrtimer_run_queues+0x100/0x280
>>           []  hrtimer_interrupt+0x100/0x220
>>           []  smp_apic_timer_interrupt+0x6a/0x130
>>           []  apic_timer_interrupt+0xf/0x20
>>
>> sched_rt_period_timer does:
>>                 raw_spin_lock(&rq->lock);
>>                 update_rq_clock(rq);
>>
>> which triggers the warning because of not using the rq_lock wrappers.
>> So, use the wrappers.
>>
>> Signed-off-by: Phil Auld <pauld@...hat.com>
>> Cc: Peter Zijlstra (Intel) <peterz@...radead.org>
>> Cc: Ingo Molnar <mingo@...hat.com>
>> Cc: Valentin Schneider <valentin.schneider@....com>
>> Cc: Dietmar Eggemann <dietmar.eggemann@....com>
> 
> Looks sane to me, and no missing _irqsave this time around ;)
> 
> Reviewed-by: Valentin Schneider <valentin.schneider@....com>
> 

Stumbled on that one while reviewing my inbox, ping?