linux-kernel - Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190916090741.GA31747@linux.intel.com>
Date:   Mon, 16 Sep 2019 12:07:41 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Seunghun Han <kkamagui@...il.com>
Cc:     Vanya Lazeev <ivan.lazeev@...il.com>, arnd@...db.de,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "open list:TPM DEVICE DRIVER" <linux-integrity@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Peter Huewe <peterhuewe@....de>
Subject: Re: [PATCH v2] Fix fTPM on AMD Zen+ CPUs

On Mon, Sep 16, 2019 at 02:29:01PM +0900, Seunghun Han wrote:
> >
> > On Fri, Sep 13, 2019 at 03:00:06PM +0100, Jarkko Sakkinen wrote:
> > > On Wed, Sep 11, 2019 at 02:17:48PM +0900, Seunghun Han wrote:
> > > > Vanya,
> > > > I also made a patch series to solve AMD's fTPM. My patch link is here,
> > > > https://lkml.org/lkml/2019/9/9/132 .
> > > >
> > > > The maintainer, Jarkko, wanted me to remark on your patch, so I would
> > > > like to cooperate with you.
> > > >
> > > > Your patch is good for me. If you are fine, I would like to take your
> > > > patch and merge it with my patch series. I also would like to change
> > > > some points Jason mentioned before.
> > >
> > > I rather handle the review processes separately because I can merge
> > > Vanyas's patch first. Bundling them into patch set would only slow
> > > down things.
> >
> > I did not ask to do anything. I just review code changes.
> 
> I got it. I should concentrate on my ACPI NVS problem.
> Thank you.

Eessentially what you want to do is to detach and backup the original
NVS resources and put them back to the list with insert_resource() when
tpm_crb is removed. At least I think this is what should be done but you
should CC your patch also to the ACPI list for feedback.

/Jarkko