linux-kernel - Re: [PATCH] tpm: Fix tpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201909161739.iQLjdTiR%lkp@intel.com>
Date:   Mon, 16 Sep 2019 17:52:57 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     kbuild-all@...org, linux-integrity@...r.kernel.org,
        Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
        Mimi Zohar <zohar@...ux.ibm.com>, stable@...r.kernel.org,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tpm: Fix tpm_send() length calculation

Hi Jarkko,

I love your patch! Yet something to improve:

[auto build test ERROR on jss-tpmdd/next]
[cannot apply to v5.3 next-20190915]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jarkko-Sakkinen/tpm-Fix-tpm_send-length-calculation/20190916-162814
base:   git://git.infradead.org/users/jjs/linux-tpmdd next
config: x86_64-randconfig-a004-201937 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/char/tpm/tpm-interface.c: In function 'tpm_send':
>> drivers/char/tpm/tpm-interface.c:366:5: error: 'struct tpm_buf' has no member named 'length'
     buf.length = buflen;
        ^

vim +366 drivers/char/tpm/tpm-interface.c

   343	
   344	/**
   345	 * tpm_send - send a TPM command
   346	 * @chip:	a &struct tpm_chip instance, %NULL for the default chip
   347	 * @cmd:	a TPM command buffer
   348	 * @buflen:	the length of the TPM command buffer
   349	 *
   350	 * Return: same as with tpm_transmit_cmd()
   351	 */
   352	int tpm_send(struct tpm_chip *chip, void *cmd, size_t buflen)
   353	{
   354		struct tpm_buf buf;
   355		int rc;
   356	
   357		chip = tpm_find_get_ops(chip);
   358		if (!chip)
   359			return -ENODEV;
   360	
   361		rc = tpm_buf_init(&buf, 0, 0);
   362		if (rc)
   363			goto out;
   364	
   365		memcpy(buf.data, cmd, buflen);
 > 366		buf.length = buflen;
   367	
   368		rc = tpm_transmit_cmd(chip, &buf, 0, "attempting to a send a command");
   369		tpm_buf_destroy(&buf);
   370	out:
   371		tpm_put_ops(chip);
   372		return rc;
   373	}
   374	EXPORT_SYMBOL_GPL(tpm_send);
   375	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (25235 bytes)