[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190916120816.GA30453@vmlxhi-102.adit-jv.com>
Date: Mon, 16 Sep 2019 14:08:16 +0200
From: Eugeniu Rosca <erosca@...adit-jv.com>
To: Shuah Khan <shuah@...nel.org>
CC: "George G. Davis" <george_davis@...tor.com>,
Jerry Hoemann <jerry.hoemann@....com>,
Colin Ian King <colin.king@...onical.com>,
<linux-kselftest@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
Eugeniu Rosca <erosca@...adit-jv.com>,
Eugeniu Rosca <roscaeugeniu@...il.com>
Subject: Re: [PATCH 1/2] selftests: watchdog: Validate optional file argument
Hi Shuah,
On Sat, Sep 07, 2019 at 10:58:32AM +0200, Eugeniu Rosca wrote:
> From: "George G. Davis" <george_davis@...tor.com>
>
> As reported by Eugeniu Rosca, the newly added optional file
> argument does not validate if the file is indeed a watchdog, e.g.:
>
> ./watchdog-test -f /dev/zero
> Watchdog Ticking Away!
>
> Fix it by confirming that the WDIOC_GETSUPPORT ioctl succeeds.
>
> Reported-by: Eugeniu Rosca <erosca@...adit-jv.com>
> Signed-off-by: George G. Davis <george_davis@...tor.com>
> Signed-off-by: Eugeniu Rosca <erosca@...adit-jv.com>
> ---
> v1: Applied/tested on commit ce54eab71e210f ("kunit: fix failure to build without printk") of
> https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/log/?h=next
Any concerns about the two patches?
Can you please confirm they are in your queue?
--
Best Regards,
Eugeniu.
Powered by blists - more mailing lists