linux-kernel - Re: [PATCH v4] numa: make node_to_cpumask_map() NUMA_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190916122359.GG10231@dhcp22.suse.cz>
Date:   Mon, 16 Sep 2019 14:23:59 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Yunsheng Lin <linyunsheng@...wei.com>
Cc:     catalin.marinas@....com, will@...nel.org, mingo@...hat.com,
        bp@...en8.de, rth@...ddle.net, ink@...assic.park.msu.ru,
        mattst88@...il.com, benh@...nel.crashing.org, paulus@...ba.org,
        mpe@...erman.id.au, heiko.carstens@...ibm.com, gor@...ux.ibm.com,
        borntraeger@...ibm.com, ysato@...rs.sourceforge.jp,
        dalias@...c.org, davem@...emloft.net, ralf@...ux-mips.org,
        paul.burton@...s.com, jhogan@...nel.org, jiaxun.yang@...goat.com,
        chenhc@...ote.com, akpm@...ux-foundation.org, rppt@...ux.ibm.com,
        anshuman.khandual@....com, tglx@...utronix.de, cai@....pw,
        robin.murphy@....com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, hpa@...or.com, x86@...nel.org,
        dave.hansen@...ux.intel.com, luto@...nel.org, peterz@...radead.org,
        len.brown@...el.com, axboe@...nel.dk, dledford@...hat.com,
        jeffrey.t.kirsher@...el.com, linux-alpha@...r.kernel.org,
        naveen.n.rao@...ux.vnet.ibm.com, mwb@...ux.vnet.ibm.com,
        linuxppc-dev@...ts.ozlabs.org, linux-s390@...r.kernel.org,
        linux-sh@...r.kernel.org, sparclinux@...r.kernel.org,
        tbogendoerfer@...e.de, linux-mips@...r.kernel.org,
        rafael@...nel.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH v4] numa: make node_to_cpumask_map() NUMA_NO_NODE aware

On Mon 16-09-19 20:07:22, Yunsheng Lin wrote:
[...]
> >> @@ -861,9 +861,12 @@ void numa_remove_cpu(int cpu)
> >>   */
> >>  const struct cpumask *cpumask_of_node(int node)
> >>  {
> >> -	if (node >= nr_node_ids) {
> >> +	if (node == NUMA_NO_NODE)
> >> +		return cpu_online_mask;
> >> +
> >> +	if ((unsigned int)node >= nr_node_ids) {
> >>  		printk(KERN_WARNING
> >> -			"cpumask_of_node(%d): node > nr_node_ids(%u)\n",
> >> +			"cpumask_of_node(%d): node >= nr_node_ids(%u)\n",
> >>  			node, nr_node_ids);
> >>  		dump_stack();
> >>  		return cpu_none_mask;
> > 
> > Why do we need this?
> 
> As the commit log says, the above cpumask_of_node() is for debugging,
> it should catch other "node < 0" cases except NUMA_NO_NODE.

OK, I would just make it a separate patch.

-- 
Michal Hocko
SUSE Labs