linux-kernel - Re: [PATCH 2/2] pwm: core: Add option to config PWM duty/period with u64 data length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Sep 2019 21:59:58 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Guru Das Srinagesh <gurus@...eaurora.org>
Cc:     kbuild-all@...org, linux-pwm@...r.kernel.org,
        Thierry Reding <thierry.reding@...il.com>,
        kernel-team@...roid.com, Mark Salyzyn <salyzyn@...gle.com>,
        Sandeep Patil <sspatil@...gle.com>,
        Subbaraman Narayanamurthy <subbaram@...eaurora.org>,
        linux-kernel@...r.kernel.org, Fenglin Wu <fenglinw@...eaurora.org>,
        Guru Das Srinagesh <gurus@...eaurora.org>
Subject: Re: [PATCH 2/2] pwm: core: Add option to config PWM duty/period with
 u64 data length

Hi Guru,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190915]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Guru-Das-Srinagesh/pwm-Add-different-PWM-output-types-support/20190916-151008
config: i386-randconfig-h004-201937 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   ld: drivers/hwmon/pwm-fan.o: in function `pwm_fan_resume':
>> drivers/hwmon/pwm-fan.c:440: undefined reference to `__udivdi3'

vim +440 drivers/hwmon/pwm-fan.c

d82d57767c8598 Kamil Debski    2014-07-16  420  
d82d57767c8598 Kamil Debski    2014-07-16  421  static int pwm_fan_resume(struct device *dev)
d82d57767c8598 Kamil Debski    2014-07-16  422  {
d82d57767c8598 Kamil Debski    2014-07-16  423  	struct pwm_fan_ctx *ctx = dev_get_drvdata(dev);
2289711c9d4d58 Boris Brezillon 2016-04-14  424  	struct pwm_args pargs;
48b9d5b4f40825 Kamil Debski    2014-11-03  425  	unsigned long duty;
48b9d5b4f40825 Kamil Debski    2014-11-03  426  	int ret;
d82d57767c8598 Kamil Debski    2014-07-16  427  
b57e1d42939721 Stefan Wahren   2019-02-22  428  	if (ctx->reg_en) {
b57e1d42939721 Stefan Wahren   2019-02-22  429  		ret = regulator_enable(ctx->reg_en);
b57e1d42939721 Stefan Wahren   2019-02-22  430  		if (ret) {
b57e1d42939721 Stefan Wahren   2019-02-22  431  			dev_err(dev, "Failed to enable fan supply: %d\n", ret);
b57e1d42939721 Stefan Wahren   2019-02-22  432  			return ret;
b57e1d42939721 Stefan Wahren   2019-02-22  433  		}
b57e1d42939721 Stefan Wahren   2019-02-22  434  	}
b57e1d42939721 Stefan Wahren   2019-02-22  435  
48b9d5b4f40825 Kamil Debski    2014-11-03  436  	if (ctx->pwm_value == 0)
d82d57767c8598 Kamil Debski    2014-07-16  437  		return 0;
48b9d5b4f40825 Kamil Debski    2014-11-03  438  
2289711c9d4d58 Boris Brezillon 2016-04-14  439  	pwm_get_args(ctx->pwm, &pargs);
2289711c9d4d58 Boris Brezillon 2016-04-14 @440  	duty = DIV_ROUND_UP(ctx->pwm_value * (pargs.period - 1), MAX_PWM);
2289711c9d4d58 Boris Brezillon 2016-04-14  441  	ret = pwm_config(ctx->pwm, duty, pargs.period);
48b9d5b4f40825 Kamil Debski    2014-11-03  442  	if (ret)
48b9d5b4f40825 Kamil Debski    2014-11-03  443  		return ret;
48b9d5b4f40825 Kamil Debski    2014-11-03  444  	return pwm_enable(ctx->pwm);
d82d57767c8598 Kamil Debski    2014-07-16  445  }
d82d57767c8598 Kamil Debski    2014-07-16  446  #endif
d82d57767c8598 Kamil Debski    2014-07-16  447  

:::::: The code at line 440 was first introduced by commit
:::::: 2289711c9d4d588954ff86a06685f1579bf6c446 hwmon: pwm-fan: Use pwm_get_args() where appropriate

:::::: TO: Boris Brezillon <boris.brezillon@...e-electrons.com>
:::::: CC: Thierry Reding <thierry.reding@...il.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (37366 bytes)