linux-kernel - Re: [PATCH] locking: locktorture: Do not include rwlock.h directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190916153651.GW30224@paulmck-ThinkPad-P72>
Date:   Mon, 16 Sep 2019 08:36:51 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, Davidlohr Bueso <dave@...olabs.net>,
        Josh Triplett <josh@...htriplett.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] locking: locktorture: Do not include rwlock.h directly

On Mon, Sep 16, 2019 at 04:54:04PM +0200, Sebastian Andrzej Siewior wrote:
> From: Wolfgang M. Reimer <linuxball@...il.com>
> 
> Including rwlock.h directly will cause kernel builds to fail
> if CONFIG_PREEMPT_RT is defined. The correct header file
> (rwlock_rt.h OR rwlock.h) will be included by spinlock.h which
> is included by locktorture.c anyway.
> 
> Remove the include of linux/rwlock.h.
> 
> Signed-off-by: Wolfgang M. Reimer <linuxball@...il.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Queued for further review and testing, thank you both!

							Thanx, Paul

> ---
>  kernel/locking/locktorture.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
> index c513031cd7e33..9fb042d610d23 100644
> --- a/kernel/locking/locktorture.c
> +++ b/kernel/locking/locktorture.c
> @@ -16,7 +16,6 @@
>  #include <linux/kthread.h>
>  #include <linux/sched/rt.h>
>  #include <linux/spinlock.h>
> -#include <linux/rwlock.h>
>  #include <linux/mutex.h>
>  #include <linux/rwsem.h>
>  #include <linux/smp.h>
> -- 
> 2.23.0
>