[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <fb06edbf-e599-ada5-916d-405382cb6f6f@kernel.org>
Date: Mon, 16 Sep 2019 09:47:21 -0600
From: shuah <shuah@...nel.org>
To: Mao Wenan <maowenan@...wei.com>, valentina.manea.m@...il.com,
gregkh@...uxfoundation.org
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org, shuah <shuah@...nel.org>
Subject: Re: [PATCH v3] usbip: vhci_hcd indicate failed message
On 9/16/19 9:09 AM, Mao Wenan wrote:
> If the return value of vhci_init_attr_group and
> sysfs_create_group is non-zero, which mean they failed
> to init attr_group and create sysfs group, so it would
> better add 'failed' message to indicate that.
> This patch also change pr_err to dev_err to trace which
> device is failed.
>
> Fixes: 0775a9cbc694 ("usbip: vhci extension: modifications to vhci driver")
> Signed-off-by: Mao Wenan <maowenan@...wei.com>
> ---
> v2: change pr_err to dev_err.
> v3: add error code in failed messages.
> drivers/usb/usbip/vhci_hcd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 000ab7225717..144507751eae 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1185,12 +1185,12 @@ static int vhci_start(struct usb_hcd *hcd)
> if (id == 0 && usb_hcd_is_primary_hcd(hcd)) {
> err = vhci_init_attr_group();
> if (err) {
> - pr_err("init attr group\n");
> + dev_err(hcd_dev(hcd), "init attr group failed, err = %d\n", err);
> return err;
> }
> err = sysfs_create_group(&hcd_dev(hcd)->kobj, &vhci_attr_group);
> if (err) {
> - pr_err("create sysfs files\n");
> + dev_err(hcd_dev(hcd), "create sysfs files failed, err = %d\n", err);
> vhci_finish_attr_group();
> return err;
> }
>
Looks good to me.
Acked-by: Shuah Khan <skhan@...uxfoundation.org>
thanks,
-- Shuah
Powered by blists - more mailing lists