linux-kernel - Re: [PATCH] s390/cio: fix intparm documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <alpine.LFD.2.21.1909161946570.3883@schleppi>
Date:   Mon, 16 Sep 2019 19:53:10 +0200 (CEST)
From:   Sebastian Ott <sebott@...ux.ibm.com>
To:     Cornelia Huck <cohuck@...hat.com>
cc:     Peter Oberparleiter <oberpar@...ux.ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] s390/cio: fix intparm documentation

On Wed, 11 Sep 2019, Cornelia Huck wrote:
> The common I/O layer is maintaining an "intparm" inspired by
> the hardware intparm for driver usage. This "intparm" is not
> only applicaple for ssch, but also for hsch/csch. The kerneldoc
> states that it is only updated for hsch/csch if no prior request
> is pending; however, this is not what the code does (whether
> that would actually desireable is a different issue.)
> 
> Let's at least fix the kerneldoc for now.
> 
> Fixes: b2ffd8e9a76e ("[S390] cio: Add docbook comments.")
> Signed-off-by: Cornelia Huck <cohuck@...hat.com>

I did a similar patch after a discusion with a colleague a couple of
months ago but totally forgot about that... yours has better description
and kdoc anyway ;-)

Applied. Thanks!