linux-kernel - Re: [PATCH v5 1/9] leds: multicolor: Add sysfs interface definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4915583c-5381-72fd-8d4f-6901018f5c3e@gmail.com>
Date:   Mon, 16 Sep 2019 20:31:31 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Dan Murphy <dmurphy@...com>, pavel@....cz
Cc:     robh+dt@...nel.org, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/9] leds: multicolor: Add sysfs interface definition

Dan,

On 9/16/19 3:56 PM, Dan Murphy wrote:
> Hello
> 
> On 9/15/19 8:57 AM, Jacek Anaszewski wrote:
>> Hi Dan,
>>
>> On 9/11/19 8:01 PM, Dan Murphy wrote:
>>> Add a documentation of LED Multicolor LED class specific
>>> sysfs attributes.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy@...com>
>>> ---
>>>   .../ABI/testing/sysfs-class-led-multicolor    | 73 +++++++++++++++++++
>>>   1 file changed, 73 insertions(+)
>>>   create mode 100644
>>> Documentation/ABI/testing/sysfs-class-led-multicolor
>>>
>>> diff --git a/Documentation/ABI/testing/sysfs-class-led-multicolor
>>> b/Documentation/ABI/testing/sysfs-class-led-multicolor
>>> new file mode 100644
>>> index 000000000000..4ea54c2ad4c8
>>> --- /dev/null
>>> +++ b/Documentation/ABI/testing/sysfs-class-led-multicolor
>>> @@ -0,0 +1,73 @@
>>> +What:        /sys/class/leds/<led>/brightness
>>> +Date:        Sept 2019
>>> +KernelVersion:    5.5
>>> +Contact:    Dan Murphy <dmurphy@...com>
>>> +Description:    read/write
>>> +        The multicolor class will redirect the device drivers call back
>>> +        function for brightness control to the multicolor class
>>> +        brightness control function.
>>> +
>>> +        Writing to this file will update all LEDs within the group to a
>>> +        calculated percentage of what each color LED in the group is
>>> set
>>> +        to.  The percentage is calculated via the equation below:
>>> +
>>> +        led_brightness = requested_value *
>>> led_color_intensity/led_color_max_intensity
>>> +
>>> +        For additional details please refer to
>>> +        Documentation/leds/leds-class-multicolor.rst.
>>> +
>>> +        The value of the color is from 0 to
>>> +        /sys/class/leds/<led>/max_brightness.
>>> +
>>> +What:        /sys/class/leds/<led>/colors/color_mix
>>> +Date:        Sept 2019
>>> +KernelVersion:    5.5
>>> +Contact:    Dan Murphy <dmurphy@...com>
>>> +Description:    read/write
>>> +        The values written to this file should contain the intensity
>>> +        values of each multicolor LED within the colors directory. The
>>> +        index of given color is reported by the color_id file
>>> present in
>>> +        colors/<color> directory. The index determines the position in
>>> +        the sequence of    intensities on which the related intensity
>>> +        should be passed to this file.
>>> +
>>> +        For additional details please refer to
>>> +        Documentation/leds/leds-class-multicolor.rst.
>> As already mentioned in the reply to Pavel - let's avoid the
>> introduction of another sysfs file with multiple values.
> 
> OK for clarification remove the color_mix and color_id files and keep
> the intensity files?

Exactly.

-- 
Best regards,
Jacek Anaszewski