linux-kernel - Re: [PATCH] soc: qcom: socinfo: add missing soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d7fe5d1.1c69fb81.eca3b.1121@mx.google.com>
Date:   Mon, 16 Sep 2019 12:43:11 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        andy.gross@...aro.org, bjorn.andersson@...aro.org
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Subject: Re: [PATCH] soc: qcom: socinfo: add missing soc_id sysfs entry

Quoting Srinivas Kandagatla (2019-09-12 02:10:19)
> looks like SoC ID is not exported to sysfs for some reason.
> This patch adds it!
> 
> This is mostly used by userspace libraries like SNPE.

What is SNPE?

> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>  drivers/soc/qcom/socinfo.c | 2 ++
>  1 file changed, 2 insertions(+)

Hmm I wasn't aware this driver was merged.

> 
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 8dc86a74559b..876a3f6612a3 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -422,6 +422,8 @@ static int qcom_socinfo_probe(struct platform_device *pdev)
>         qs->attr.family = "Snapdragon";
>         qs->attr.machine = socinfo_machine(&pdev->dev,
>                                            le32_to_cpu(info->id));
> +       qs->attr.soc_id = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%u",
> +                                        le32_to_cpu(info->id));
>         qs->attr.revision = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%u.%u",
>                                            SOCINFO_MAJOR(le32_to_cpu(info->ver)),
>                                            SOCINFO_MINOR(le32_to_cpu(info->ver)));