lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190916200029.GA27567@hv-1.home>
Date:   Mon, 16 Sep 2019 23:00:30 +0300
From:   Vanya Lazeev <ivan.lazeev@...il.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] tpm_crb: fix fTPM on AMD Zen+ CPUs

On Mon, Sep 16, 2019 at 08:51:30AM +0300, Jarkko Sakkinen wrote:
> On Sat, Sep 14, 2019 at 08:17:44PM +0300, ivan.lazeev@...il.com wrote:
> > +	struct list_head acpi_resources, crb_resources;
> 
> Please do not create crb_resources. I said this already last time.

But then, if I'm not mistaken, it will be impossible to track pointers
to multiple remaped regions. In this particular case, it
doesn't matter, because both buffers are in different ACPI regions,
and using acpi_resources only to fix buffer will be enough.
However, this creates incosistency between single- and
multiple-region cases: in the latter iobase field of struct crb_priv
doesn't make any difference. Am I understanding the situation correctly?
Will such fix be ok?

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ