linux-kernel - Re: [PATCH v2 2/2] powerpc/83xx: map IMMR with a BAT.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <faa12987-1c3d-b554-de03-cb1be34112ad@c-s.fr>
Date:   Mon, 16 Sep 2019 22:18:05 +0200
From:   Christophe Leroy <christophe.leroy@....fr>
To:     Scott Wood <oss@...error.net>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        galak@...nel.crashing.org
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 2/2] powerpc/83xx: map IMMR with a BAT.



Le 16/09/2019 à 17:04, Scott Wood a écrit :
> On Mon, 2019-09-16 at 06:42 +0000, Christophe Leroy wrote:
>> @@ -145,6 +147,15 @@ void __init mpc83xx_setup_arch(void)
>>   	if (ppc_md.progress)
>>   		ppc_md.progress("mpc83xx_setup_arch()", 0);
>>   
>> +	if (!__map_without_bats) {
>> +		phys_addr_t immrbase = get_immrbase();
>> +		int immrsize = IS_ALIGNED(immrbase, SZ_2M) ? SZ_2M : SZ_1M;
>> +		unsigned long va = __fix_to_virt(FIX_IMMR_BASE);
> 
> Why __fix_to_virt() and not fix_to_virt()?
> 

Euh ... because I copy/pasted it from 
/arch/powerpc/include/asm/nohash/32/mmu-8xx.h

But yes I can do fix_to_virt() instead.

Christophe