linux-kernel - Re: [PATCH] drm/amd/display: Fix compile error due to 'endif' missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190916223152.GO4352@sirena.co.uk>
Date:   Mon, 16 Sep 2019 23:31:52 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Austin Kim <austindh.kim@...il.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, Roman.Li@....com,
        amd-gfx@...ts.freedesktop.org,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amd/display: Fix compile error due to 'endif' missing

On Tue, Sep 17, 2019 at 02:46:48AM +0900, Masahiro Yamada wrote:
> On Mon, Sep 16, 2019 at 1:46 PM Austin Kim <austindh.kim@...il.com> wrote:

> > gcc throws compile error with below message:

> GNU Make throws ...

Xinpeng Liu via Nick Desaulniers sent a description of the problem and a
patch so I think I'll be able to fix this.  However...

> This is probably a merge mistake in linux-next.

> If so, this should be directly fixed in the linux-next.

> If it is not fixed in time,
> please inform Linus to *not* follow the linux-next.

...as I said before I think you definitely need to coordinate with the
DRM people - Nick Desaulniers' patch 0f0727d971f6f (drm/amd/display:
readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP
routines) breaks in places that don't have merge conflicts due to this
change.  I wouldn't rely on the merge going well if things are sent
as-is, the only reason this one showed up was that other people were
adding new files to the Makefile.

I've CCed Nick.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)