linux-kernel - Re: treewide replacement of fallthrough comments with "fallthrough" macro (was Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201909171638.A05CD47@keescook>
Date:   Tue, 17 Sep 2019 16:38:54 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Joe Perches <joe@...ches.com>
Cc:     hpa@...or.com, Peter Zijlstra <peterz@...radead.org>,
        Pavel Machek <pavel@....cz>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "Gustavo A . R . Silva" <gustavo@...eddedor.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Shawn Landden <shawn@....icu>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: treewide replacement of fallthrough comments with "fallthrough"
 macro (was Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo
 keyword for switch/case use)

On Tue, Sep 17, 2019 at 03:26:32PM -0700, Joe Perches wrote:
> On Mon, 2019-09-16 at 15:19 -0700, Kees Cook wrote:
> > On Thu, Aug 15, 2019 at 11:15:53AM -0700, Kees Cook wrote:
> > > With that out of the way, yes, let's do a mass conversion. As mentioned
> > > before, I think "fallthrough;" should be used here (to match "break;").
> > > Let's fork the C language. :)
> > 
> > FWIW, last week I asked Linus at the maintainer's summit which he
> > preferred ("__fallthrough" or "fallthrough") and he said "fallthrough".
> 
> Nice.  I think that's better style/taste.
> 
> > Joe, if you've still got the series ready, do you want to send it for
> > this merge window before -rc1 gets cut?
> 
> The first bits that add fallthrough and converts the one existing
> use of fallthrough as a label can be sent now.  I'll do that in
> a few days as I'm not able to do that right now.

Okay, sounds good.

> Sending any actual comment conversion patches before -rc1 might
> require changes in already queued up and tested patches
> 
> I do think a scripted conversion by major subsystem/directory
> might be a better mechanism than individual patches, especially
> if applied directly before releasing what will be -rc1.

Yeah, as long as we've got the infrastructure in place, the scripted
conversion can land whenever is easiest.

Thanks!

-- 
Kees Cook