linux-kernel - Re: [PATCH 2/5] powerpc: Map & release OpenCAPI LPC memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201909171259.fepclpk8%lkp@intel.com>
Date:   Tue, 17 Sep 2019 12:22:38 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Alastair D'Silva <alastair@....ibm.com>
Cc:     kbuild-all@...org, alastair@...ilva.org,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Frederic Barrat <fbarrat@...ux.ibm.com>,
        Andrew Donnellan <ajd@...ux.ibm.com>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mahesh Salgaonkar <mahesh@...ux.vnet.ibm.com>,
        Allison Randal <allison@...utok.net>,
        Anju T Sudhakar <anju@...ux.vnet.ibm.com>,
        Vaibhav Jain <vaibhav@...ux.ibm.com>,
        Cédric Le Goater <clg@...d.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        David Gibson <david@...son.dropbear.id.au>,
        Alexey Kardashevskiy <aik@...abs.ru>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Nicholas Piggin <npiggin@...il.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] powerpc: Map & release OpenCAPI LPC memory

Hi Alastair,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190916]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Alastair-D-Silva/ocxl-Allow-external-drivers-to-access-LPC-memory/20190917-094857
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/powerpc/platforms/powernv/ocxl.c: In function 'pnv_ocxl_platform_lpc_setup':
>> arch/powerpc/platforms/powernv/ocxl.c:492:7: error: implicit declaration of function 'check_hotplug_memory_addressable' [-Werror=implicit-function-declaration]
     rc = check_hotplug_memory_addressable(base_addr, base_addr + size);
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/check_hotplug_memory_addressable +492 arch/powerpc/platforms/powernv/ocxl.c

   477	
   478	u64 pnv_ocxl_platform_lpc_setup(struct pci_dev *pdev, u64 size)
   479	{
   480		struct pci_controller *hose = pci_bus_to_host(pdev->bus);
   481		struct pnv_phb *phb = hose->private_data;
   482		struct pci_dn *pdn = pci_get_pdn(pdev);
   483		u32 bdfn = (pdn->busno << 8) | pdn->devfn;
   484		u64 base_addr = 0;
   485	
   486		int rc = opal_npu_mem_alloc(phb->opal_id, bdfn, size, &base_addr);
   487	
   488		WARN_ON(rc);
   489	
   490		base_addr = be64_to_cpu(base_addr);
   491	
 > 492		rc = check_hotplug_memory_addressable(base_addr, base_addr + size);
   493		if (rc) {
   494			dev_warn(&pdev->dev,
   495				 "LPC memory range 0x%llx-0x%llx is not fully addressable",
   496				 base_addr, base_addr + size - 1);
   497			return 0;
   498		}
   499	
   500	
   501		return base_addr;
   502	}
   503	EXPORT_SYMBOL_GPL(pnv_ocxl_platform_lpc_setup);
   504	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (62351 bytes)