linux-kernel - Re: [PATCH v2] platform/chrome: wilco_ec: Add debugfs test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201909180722.Rq0b1WMA%lkp@intel.com>
Date:   Wed, 18 Sep 2019 07:49:08 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Daniel Campello <campello@...omium.org>
Cc:     kbuild-all@...org, LKML <linux-kernel@...r.kernel.org>,
        Daniel Campello <campello@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Benson Leung <bleung@...omium.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Duncan Laurie <dlaurie@...gle.com>,
        Nick Crews <ncrews@...omium.org>
Subject: Re: [PATCH v2] platform/chrome: wilco_ec: Add debugfs test_event file

Hi Daniel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[cannot apply to v5.3 next-20190916]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Daniel-Campello/platform-chrome-wilco_ec-Add-debugfs-test_event-file/20190918-055910
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from drivers/platform/chrome/wilco_ec/debugfs.c:11:0:
   drivers/platform/chrome/wilco_ec/debugfs.c: In function 'fops_test_event_open':
>> include/linux/debugfs.h:43:56: warning: too many arguments for format [-Wformat-extra-args]
    static int __fops ## _open(struct inode *inode, struct file *file) \
                                                           ^
>> drivers/platform/chrome/wilco_ec/debugfs.c:230:1: note: in expansion of macro 'DEFINE_DEBUGFS_ATTRIBUTE'
    DEFINE_DEBUGFS_ATTRIBUTE(fops_test_event, NULL, test_event_set, NULL);
    ^~~~~~~~~~~~~~~~~~~~~~~~
--
   In file included from drivers/platform//chrome/wilco_ec/debugfs.c:11:0:
   drivers/platform//chrome/wilco_ec/debugfs.c: In function 'fops_test_event_open':
>> include/linux/debugfs.h:43:56: warning: too many arguments for format [-Wformat-extra-args]
    static int __fops ## _open(struct inode *inode, struct file *file) \
                                                           ^
   drivers/platform//chrome/wilco_ec/debugfs.c:230:1: note: in expansion of macro 'DEFINE_DEBUGFS_ATTRIBUTE'
    DEFINE_DEBUGFS_ATTRIBUTE(fops_test_event, NULL, test_event_set, NULL);
    ^~~~~~~~~~~~~~~~~~~~~~~~

vim +/DEFINE_DEBUGFS_ATTRIBUTE +230 drivers/platform/chrome/wilco_ec/debugfs.c

   226	
   227	/* Format set to NULL since it is only used on read operations which are
   228	 * forbidden by file permissions.
   229	 */
 > 230	DEFINE_DEBUGFS_ATTRIBUTE(fops_test_event, NULL, test_event_set, NULL);
   231	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (70298 bytes)